Repository navigation
Editor: no boxes around typographic characters; invisible ones stay marked - #42
Merged
Merged
Conversation
Monaco boxes characters that look like others (e.g. «–» like "-") and invisible ones. In strings and comments (docstrings with a course's German text) it no longer does; in code, where "5 – 3" is a SyntaxError, it still does, for both kinds. Monaco's switch for strings and comments covers both kinds, so an invisible character inside a string or comment isn't marked either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As decided on #42: no boxes around the typographic characters of a German text (– ‒ ‐ ‑ ‘ ’ ‚ ‛ ‹ › × ′, the ones Monaco calls ambiguous; guillemets, “ ” and … never were), anywhere. Invisible characters stay marked everywhere, also in strings and comments: in a doctest's expected output a non-breaking space fails with an Expected/Got that look the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cedricvogel-leo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P25 decision 1 (lean variant), part 1: the Monaco setting. Reworked as decided: an allow-list instead of hiding marks in strings and comments. Tag
v0.1.20after the merge.Change
The editor's
unicodeHighlight(EDITOR_UNICODE_HIGHLIGHT):–‒‐‑(dashes),‘’‚‛,‹›,×,′. Guillemets «»,“”,…and the umlauts were never boxed.аfor Latina) stay boxed."""Funktionen – vom Aufruf …""",# Kommentar – …x = 5 – 3(code)SyntaxError: invalid character '–' (U+2013)Checked
Locally in the IDE with this build, a file containing:
Exactly the four invisible characters are boxed.
Lint (known warning only), both builds.
Noted in CLAUDE.md.
🤖 Generated with Claude Code